fix(cli): resolve checkhealth false positive for uv launcher shims#4889
Open
srinu2003 wants to merge 2 commits into
Open
fix(cli): resolve checkhealth false positive for uv launcher shims#4889srinu2003 wants to merge 2 commits into
srinu2003 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
It updates the
is_manim_executable_associated_to_this_libraryhealth check inmanim/cli/checkhealth/checks.pyto supportuvtoolchain shims. If a companion.__script__.pyfile exists next to the resolvedmanimexecutable, it reads its contents and includes them in the verification check.Motivation and Explanation: Why and how do your changes improve the library?
When Manim is installed globally or managed via
uv, themanimexecutable on the user'sPATHis often a compiled Rust launcher shim (e.g.C:\Users\<username>\AppData\Local\Python\bin\manim.exe).Because this wrapper is a compiled binary, it does not contain the entrypoint string
manim.__main__directly inside it. Instead, the python entrypoint code is written to a companion script file namedmanim.exe.__script__.py. This causesmanim checkhealthto falsely report that the executable does not belong to the Manim Community library.This fix resolves the false positive warning for all users using the modern
uvPython toolchain.Links to added or changed documentation pages
Not applicable (No documentation changes required).
Further Information and Comments
This change is non-breaking, cross-platform, and falls back gracefully when no
uvshim is present.Reviewer Checklist