feat: allow deriving Trace without Drop/Finalize#116
Open
CertainLach wants to merge 3 commits intoManishearth:masterfrom
Open
feat: allow deriving Trace without Drop/Finalize#116CertainLach wants to merge 3 commits intoManishearth:masterfrom
CertainLach wants to merge 3 commits intoManishearth:masterfrom
Conversation
Custom Drop implementation still can't be written, because generated TriviallyDrop implementation tries to destruct value, which is only possible when there is no user defined Drop impl Empty Finalize impl generated too, because it will never be called Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
Owner
|
cc @kneecaw |
andersk
reviewed
Jan 3, 2021
Owner
|
cc @mystor |
CertainLach
force-pushed
the
trivially-drop
branch
from
444f54e to
456c8e9
Compare
andersk
reviewed
Feb 5, 2021
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
CertainLach
force-pushed
the
trivially-drop
branch
from
456c8e9 to
fe4fea0
Compare
Contributor
Author
|
Didn't meant to bother you with broken code, accidentally pushed, and then was busy, sorry. |
andersk
approved these changes
Feb 9, 2021
CertainLach
added a commit
to CertainLach/jrsonnet
that referenced
this pull request
Jun 5, 2021
Some manual Trace/Finalize implementations can be replaced with derives with Manishearth/rust-gc#116 getting merged Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
CertainLach
added a commit
to CertainLach/jrsonnet
that referenced
this pull request
Jun 5, 2021
Some manual Trace/Finalize implementations can be replaced with derives with Manishearth/rust-gc#116 getting merged Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
3 tasks
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
Manishearth
approved these changes
Dec 18, 2021
Owner
Manishearth
left a comment
Manishearth
left a comment
There was a problem hiding this comment.
Sorry about the delay! This looks good, happy to merge it in but would like some additional comments.
Ideally, it would be nice if this could be documented somewhere too.
| #drop_impl | ||
| } | ||
| } else { | ||
| s.bind_with(|_| BindStyle::Move); |
Owner
There was a problem hiding this comment.
Can we add some comments here as to why this branch is safe?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To allow structs with generated Trace impl to be destructured