Skip to content

Conversation

@Garandor
Copy link
Contributor

@Garandor Garandor commented Apr 4, 2023

If an asset has a valid Multilocation, we only allow to register it if we're sure it can be sent via xtokens ( i.e. passes the Contains filter )

Signed-off-by: Adam Reif [email protected]## Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@Garandor Garandor added C-bug Category: Issues documenting a bug A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime L-fixed Log: Issues and PRs related to bug fixes labels Apr 4, 2023
@Garandor Garandor requested review from bhgomes and ghzlatarev April 4, 2023 01:51
@Garandor Garandor self-assigned this Apr 4, 2023
@Garandor Garandor force-pushed the garandor/validate-multilocation branch from 6ad4586 to ed10238 Compare April 4, 2023 02:00
Adam Reif added 8 commits April 3, 2023 23:01
@Garandor Garandor requested a review from Dengjianping April 4, 2023 05:48
@Garandor Garandor force-pushed the garandor/validate-multilocation branch from b9f1eb0 to a41e44b Compare April 11, 2023 21:39
@Garandor Garandor removed their assignment Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-manta Area: Issues and PRs related to the Manta Runtime C-bug Category: Issues documenting a bug L-fixed Log: Issues and PRs related to bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants