-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): add maxFilename limit for outputConfiguration #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd max file name Most modern filesystems have max file name of 255 and very large or missing limits for max file path
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #889 +/- ##
=============================================
- Coverage 59.27% 59.24% -0.03%
- Complexity 799 802 +3
=============================================
Files 214 214
Lines 4454 4468 +14
Branches 711 717 +6
=============================================
+ Hits 2640 2647 +7
Misses 1481 1481
- Partials 333 340 +7 ☔ View full report in Codecov by Sentry. |
matzuk
previously approved these changes
Feb 4, 2024
configuration/src/main/kotlin/com/malinskiy/marathon/config/OutputConfiguration.kt
Show resolved
Hide resolved
…haviour' into feature/imporove-max-filename-behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
maxPath limits the overall output file path length
After:
Fine-grained control over max filename and max file path
Reason for change:
Most modern filesystems (ext3, ext4, NTFS, APFS, etc) have max file name of 255 and very large or missing limits for max file path.