update agent personas#122
Merged
Merged
Conversation
…into enhancements/personas
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the project’s AI agent “personas” by renaming/splitting the exploratory vs production roles (Data Explorer vs App Architect) across Copilot + Claude configurations, and aligns documentation and dependencies accordingly.
Changes:
- Replaced the former “DataViz Analyst / DataApp Architect” agents with “Data Explorer” and “App Architect” variants (Copilot + Claude).
- Updated tutorials/docs to reference the new agent names and installation steps.
- Added the
panel-splitjsdependency and updated lockfiles; added a new tutorial screenshot image.
Reviewed changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/holoviz_mcp/config/resources/agents/copilot/holoviz-dataapp-architect.agent.md | Removed legacy Copilot “DataApp Architect” agent definition. |
| src/holoviz_mcp/config/resources/agents/copilot/holoviz-data-explorer.agent.md | Renamed/updated Copilot exploratory agent persona and guidance. |
| src/holoviz_mcp/config/resources/agents/copilot/holoviz-app-architect.agent.md | Added new Copilot production “App Architect” agent persona. |
| src/holoviz_mcp/config/resources/agents/claude/holoviz-dataviz-analyst.md | Removed legacy Claude “dataviz analyst” agent definition. |
| src/holoviz_mcp/config/resources/agents/claude/holoviz-data-explorer.md | Added new Claude “data explorer” agent definition. |
| src/holoviz_mcp/config/resources/agents/claude/holoviz-app-architect.md | Renamed/expanded Claude production agent definition. |
| pyproject.toml | Added panel-splitjs to Python dependencies. |
| pixi.toml | Added panel-splitjs to Pixi environment dependencies. |
| pixi.lock | Updated lockfile to include panel-splitjs. |
| docs/tutorials/weather-dashboard-copilot-vscode.md | Updated tutorial text to reference the renamed App Architect agent. |
| docs/tutorials/stock-analysis-copilot-vscode.md | Updated tutorial to reference the renamed Data Explorer agent and new screenshot. |
| docs/tutorials/stock-analysis-claude-code.md | Adjusted tutorial prerequisites section. |
| docs/tutorials/getting-started-copilot-vscode.md | Updated getting-started steps to reference the renamed App Architect agent. |
| docs/tutorials/getting-started-claude-code.md | Moved/updated Claude agent installation instructions and references. |
| docs/tutorials/display-system.md | Formatting tweak to summary list. |
| docs/how-to/configure-claude-code.md | Updated link anchor to match new Claude tutorial step numbering. |
| docs/assets/images/stock-analysis-holoviz-data-explorer.png | Added new screenshot asset for the updated stock analysis tutorial. |
| .claude/agents/holoviz-dataviz-analyst.md | Removed legacy local Claude agent file. |
| .claude/agents/holoviz-data-explorer.md | Added new local Claude “data explorer” agent file. |
| .claude/agents/holoviz-app-architect.md | Renamed/expanded local Claude production agent file. |
Comments suppressed due to low confidence (2)
src/holoviz_mcp/config/resources/agents/copilot/holoviz-data-explorer.agent.md:58
- "high performant" is not idiomatic here; consider changing to "high-performance" (or "high-performing") for clearer, standard phrasing.
.claude/agents/holoviz-app-architect.md:201 - Minor grammar: "Tableau like" should be hyphenated as "Tableau-like" when used as a compound modifier.
| - ✅ Created the documentation index | ||
| - ✅ Installed Chromium | ||
| - ✅ Installed HoloViz Copilot agents | ||
| - ✅ Configured Github Copilot and VS Code |
There was a problem hiding this comment.
The tutorial uses "Github" here; the correct capitalization is "GitHub".
|
|
||
| ## Core Responsibilities | ||
|
|
||
| Your task is to generate an implementation plan for a a data visualization, a dashboard, a data app, a new feature or for refactoring existing code using the HoloViz ecosystem. |
There was a problem hiding this comment.
The sentence has a duplicated article ("for a a data visualization"), which reads like a typo. Please remove the extra "a" to improve clarity.
Suggested change
| Your task is to generate an implementation plan for a a data visualization, a dashboard, a data app, a new feature or for refactoring existing code using the HoloViz ecosystem. | |
| Your task is to generate an implementation plan for a data visualization, a dashboard, a data app, a new feature or for refactoring existing code using the HoloViz ecosystem. |
| You use this decision tree for Panel extensions library selection: | ||
|
|
||
| ```text | ||
| panel-graphic-walker → For building interactive data exploration tools with Tableau like drag-and-drop interfaces |
There was a problem hiding this comment.
Minor grammar: "Tableau like" should be hyphenated as "Tableau-like" when used as a compound modifier.
Suggested change
| panel-graphic-walker → For building interactive data exploration tools with Tableau like drag-and-drop interfaces | |
| panel-graphic-walker → For building interactive data exploration tools with Tableau-like drag-and-drop interfaces |
| You use this decision tree for Panel extensions library selection: | ||
|
|
||
| ```text | ||
| panel-graphic-walker → To enable the user to manually explore data using high performant grid or Tableau like drag-and-drop interfaces |
There was a problem hiding this comment.
"high performant" is not idiomatic here; consider changing to "high-performance" (or "high-performing") for clearer, standard phrasing.
Suggested change
| panel-graphic-walker → To enable the user to manually explore data using high performant grid or Tableau like drag-and-drop interfaces | |
| panel-graphic-walker → To enable the user to manually explore data using a high-performance grid or Tableau like drag-and-drop interfaces |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.