Add examples section with first example#126
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an "Examples" section to the documentation navigation and includes the vega_datasets dependency needed for data visualization examples.
Changes:
- Added
vega_datasetsto the pydata optional dependencies in pyproject.toml - Added an "Examples" section to the MkDocs navigation with references to an index page and a "Dashboard from Picture" example
Reviewed changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Adds vega_datasets to the pydata optional dependency group (alphabetically ordered) |
| mkdocs.yml | Adds Examples section to navigation with index.md and generate-dashboard-from-picture.md entries |
Comment on lines
+107
to
+109
| - Examples: | ||
| - examples/index.md | ||
| - Dashboard from Picture: examples/generate-dashboard-from-picture.md |
There was a problem hiding this comment.
The navigation references example files that don't exist in the repository. The files docs/examples/index.md and docs/examples/generate-dashboard-from-picture.md need to be created before this navigation can be added, otherwise the documentation build will fail or produce broken links.
Suggested change
| - Examples: | |
| - examples/index.md | |
| - Dashboard from Picture: examples/generate-dashboard-from-picture.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.