Add convert excel examples#133
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new documentation example for converting an Excel spreadsheet into a Panel app, and wires it into the docs navigation alongside minor Panel/Tabulator guidance updates.
Changes:
- Added a new “Convert an Excel Spreadsheet” example page with a sample workbook and screenshots.
- Updated MkDocs navigation to include the new example.
- Expanded Tabulator guidance to prefer Tabulator-native formatters/editors.
Reviewed changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/holoviz_mcp/config/resources/skills/panel.md | Adds Tabulator guidance about preferring Tabulator formatters/editors. |
| mkdocs.yml | Adds the new Excel conversion example to the Examples nav. |
| docs/examples/convert-excel-app.md | New end-to-end documentation walkthrough + embedded example code. |
| docs/assets/images/examples/convert-excel-app-image.png | Screenshot used by the new example page. |
| docs/assets/data/stock_portfolio.xlsx | Sample Excel workbook used by the new example. |
| docs/assets/data/convert-excel-app-picture.png | Additional image asset added (currently appears unused). |
|
|
||
| - DO set `Tabulator.disabled=True` unless you would like the user to be able to edit the table. | ||
| - DO prefer [Tabulator Formatters](https://tabulator.info/docs/6.3/format) over Bokeh formatters and Pandas Styling. | ||
| - DO prefer [Tabulator Editors](https://tabulator.info/docs/6.3/edit) over Bokeh Editor types |
There was a problem hiding this comment.
Add the missing trailing period to keep the Tabulator guidance bullets consistent with the surrounding style (the previous bullets in this section end with a period).
| - DO prefer [Tabulator Editors](https://tabulator.info/docs/6.3/edit) over Bokeh Editor types | |
| - DO prefer [Tabulator Editors](https://tabulator.info/docs/6.3/edit) over Bokeh Editor types. |
| I had to help Claude install the dependencies and keep pandas<3 | ||
|
|
||
| ```bash | ||
| pip install panel watchfiles pandas |
There was a problem hiding this comment.
The dependency note says to keep pandas<3, but the install command installs an unpinned pandas. Also, this example reads an .xlsx via pd.read_excel, which typically requires openpyxl to be installed; please update the install instructions to match the stated constraint and include the Excel engine dependency.
| pip install panel watchfiles pandas | |
| pip install "pandas<3" openpyxl panel watchfiles |
|
|
||
| import pandas as pd | ||
| import panel as pn | ||
| from bokeh.models.widgets.tables import NumberFormatter |
There was a problem hiding this comment.
This example uses Bokeh NumberFormatter for Tabulator formatting, but the skill guidance added in src/holoviz_mcp/config/resources/skills/panel.md:522 recommends preferring Tabulator formatters over Bokeh formatters. Consider updating the example to use Tabulator-native formatters (via Tabulator column configuration) so the docs don’t conflict.
| from bokeh.models.widgets.tables import NumberFormatter |
| Technical implementation: | ||
| - Ensure data validation for numeric inputs | ||
| - Preserve the Excel sheet's layout and structure | ||
| - Make the app responsive, professionally and user-friendly |
There was a problem hiding this comment.
In the prompt text, "Make the app responsive, professionally and user-friendly" is grammatically awkward; consider changing it to "Make the app responsive, professional, and user-friendly" (or similar).
| - Make the app responsive, professionally and user-friendly | |
| - Make the app responsive, professional, and user-friendly |
No description provided.