Enhancement/custom components skill#136
Merged
Merged
Conversation
…into enhancement/custom-compoents-skill
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a comprehensive panel-custom-components skill to the HoloViz MCP server and demonstrates its usage with a practical Model Viewer example. The skill provides extensive guidance on building custom Panel components using JSComponent, ReactComponent, AnyWidgetComponent, and MaterialUIComponent.
Changes:
- Added comprehensive skill documentation (
panel-custom-components.md) covering component types, development workflows, best practices, and Playwright testing patterns - Added example documentation (
build-custom-model-viewer.md) demonstrating how to build a custom 3D model viewer component - Updated
server.pydocstring to include the new skill in examples - Added the new example to the MkDocs navigation
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/holoviz_mcp/holoviz_mcp/server.py |
Updated list_skills() docstring to include examples of the new panel-custom-components skill |
src/holoviz_mcp/config/resources/skills/panel-custom-components.md |
New comprehensive skill covering decision guides, development workflows, patterns for all component types, best practices, testing with Playwright, and troubleshooting |
docs/examples/build-custom-model-viewer.md |
New example demonstrating how to use the skill to build a custom 3D model viewer component wrapping Google's model-viewer web component |
mkdocs.yml |
Added the new example to the Examples section of the navigation |
|
|
||
|
|
||
| # ============================================================================= | ||
| # Fixtures - CRITICAL: Always reset state to properly shuts down all threaded Panel |
There was a problem hiding this comment.
Grammar error in comment: "Always reset state to properly shuts down" should be "Always reset state to properly shut down" (remove the 's' from 'shuts').
Suggested change
| # Fixtures - CRITICAL: Always reset state to properly shuts down all threaded Panel | |
| # Fixtures - CRITICAL: Always reset state to properly shut down all threaded Panel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.