Add --unsafe

[akx]

Applies transformations that might be wrong and need human eyes to verify.

Right now this means looking at assignments etc. also within sub-scopes, and we can't currently verify whether those are "safe".

[MarcoGorelli]

thanks for your prs - have you considered upstreaming this (together with improvements) to ruff?

[akx]

An example of unsafeness:

def unique_truthy_in_order(iterable):
    seen = set()
    for item in iterable:
        if not item:
            continue
        if item not in seen:
            yield item
            seen.add(item)

👇

def unique_truthy_in_order(iterable):
    for item in iterable:
        if not item:
            continue
        if item not in (seen := set()):
            yield item
            seen.add(item)

[akx]

thanks for your prs - have you considered upstreaming this (together with improvements) to ruff?

I've contributed some things to Ruff 😄

It's just a whole lot more involved than adding a couple of simple fixes in a small Python repo like this.

[MarcoGorelli]

thanks - could you ask them if they'd be interested in doing what auto-walrus does?

because if ruff ends up doing this anyway, then i wouldn't be particularly motivated to spend time on it

[akx]

Well, there was no definite interest there (see link above).

[akx]

So WDYT, could these PRs get merged in anyway, even if Ruff isn't currently moving to walrusing?

[MarcoGorelli]

pre-commit-ci is failing

[MarcoGorelli]

thanks @akx !