Skip to content

UI: Map settings#1023

Merged
FlorianSW merged 22 commits intomasterfrom
ui/maps
Jul 11, 2025
Merged

UI: Map settings#1023
FlorianSW merged 22 commits intomasterfrom
ui/maps

Conversation

@Dorfieeee
Copy link
Copy Markdown
Collaborator

Better views for map setting pages

image

@caranci
Copy link
Copy Markdown
Collaborator

caranci commented Jun 22, 2025

Quick comments, without any consideration about effort or feasibility. :)

  1. I'm not sure what the copy button does.
  2. I think a refresh button is needed. A common flow is to mess with the rotation from yesterday, and then decide you want to start over.
  3. To be honest, I'm not sure I like the tabs. I would rather go straight to the rotation settings. And having the List tab (i.e., change current map) first seems dangerous somehow...
  4. It might be useful to have checkboxes on the weather combo-box to allow multiple-selection.
    image
  5. It would be useful if the available maps were effectively in a table-view with different columns for name, game mode, and weather, allowing people to sort by the columns to more effectively find the maps they want.
    image
  6. It would be convenient to allow drag-and-drop from the available maps list to the map rotation list.

@Dorfieeee
Copy link
Copy Markdown
Collaborator Author

@caranci I will consider the first 4 points now and leave points 5 & 6 for later. That's something I would like too but it will require extra time to develop.

@caranci
Copy link
Copy Markdown
Collaborator

caranci commented Jun 22, 2025

Fair enough!

@Dorfieeee Dorfieeee marked this pull request as ready for review June 25, 2025 22:23
@caranci
Copy link
Copy Markdown
Collaborator

caranci commented Jun 27, 2025

Maps>Change page

  1. Server live… didn't test any changing the map. Is there an "are you sure" pop-up? Might be a good idea if there isn't.

Maps>Rotation>Builder page

  1. Calling the refresh button "undo" is a bit misleading. Undo implies the last change will be reverted, but the button really refreshes the list from what is currently running on the server.
  2. I like the "table-like" layout of the tiles in the map lists.
  3. I like the check-boxes in the combo-boxes.
  4. I didn't test the save button… server is seeded…

Maps>Objectives>Map Objectives

  1. Looks intuitive and seems to work.
  2. Server live… didn't test "confirm" button. Is there an "are you sure" pop-up? Might be a good idea if there isn't.

Maps>Votemap>Whitelist>Status

  1. We aren't using it at the moment, so I don't know if the status works.
  2. Looks easy to understand.

Maps>Votemap>Whitelist>Map Whitelist

  1. Search / filtering for the list of maps currently whitelisted would be useful.
  2. When all the maps are in the whitelist the "No maps found -- Try adjusting your filters or search term" note is a bit confusing. There just aren't any maps at all because they are all in the whitelist. :) There is also a moment where the page renders all the maps in the available list before it filters the ones that are whitelisted… and this slight delay makes it seem like it was broken.

Cosmetic

  1. Why don't some of the list containers extend to the bottom of the page?
    image
    image

Copy link
Copy Markdown
Collaborator

@FlorianSW FlorianSW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@FlorianSW FlorianSW merged commit 47705b3 into master Jul 11, 2025
3 checks passed
@FlorianSW FlorianSW deleted the ui/maps branch July 11, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants