Skip to content

VIP rework to VIP Lists#1253

Draft
Dorfieeee wants to merge 2 commits intomasterfrom
feat/vip_v2
Draft

VIP rework to VIP Lists#1253
Dorfieeee wants to merge 2 commits intomasterfrom
feat/vip_v2

Conversation

@Dorfieeee
Copy link
Copy Markdown
Collaborator

@Dorfieeee Dorfieeee commented Mar 31, 2026

There were so many unwanted and outdated changes in the original branch #964 and the commits were so mixed up I decided to manually update it and create a separate branch.

  • update_profile functionality was removed since we have the player account table now.
  • created new alembic migration file to compress the original 3 into 1

Todos

  • backend
  • frontend
  • allow importing old style VIP lists

@Dorfieeee Dorfieeee requested a review from cemathey March 31, 2026 09:41
@Dorfieeee Dorfieeee added this to the 12.0.0 milestone Mar 31, 2026
@Dorfieeee
Copy link
Copy Markdown
Collaborator Author

Hey @cemathey,

is there any benefit in having multiple records per list per player?

It seems that having all add_vip_list_record, edit_vip_list_record and add_or_edit_vip_list_record is sort of redundant.
It could all replaced by upsert_vip_list_record(practically add_or_edit_vip_list_record logic) endpoint for example as I don't see any point in using the other two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants