Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use type equality instead of .Equals #4554

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SimonCropp
Copy link
Contributor

No description provided.

@StefanOssendorf
Copy link
Contributor

Out of curiosity: What's the benefit using one over the other?

@hurcane
Copy link

hurcane commented Mar 9, 2025

I see that all of these changes involve System.Type comparisons. If I am remembering correctly, the == operator is stricter than the Equals method. The == operator does reference equality. The Equals method returns true if the underlying types are the same. System.Type.Equals will return true on types that are different but inherit from the same root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants