Remove redundant comments #4594
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@StefanOssendorf want me to handle the conflicts? |
|
Why do they negatively affect readability? I'm personally for full comments here. Especially with public types. |
|
While I would prefer completing the comments, I am ok with removing empty comment blocks. I do NOT want to disable warnings about comments, because comments should exist - especially for public APIs. I have a local branch where I've been working on automatic creation of docs as part of the build. In the past people have volunteered to create the docs, but that should be part of the GitHub pipeline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since they negatively effect readability and add no value