4385- Changes to the build for maui - #4690
Conversation
csla.build.sln no longer contains Csla.xaml.maui project csla.maui.build.sln created to build csla.xaml.maui.csproj csla.xaml.maui.csproj changed to reference CSLA via a nuget reference new directory.package.props created and placed in the csla.xaml.maui directory. The primary purpose of this is to change the output directory to bin\maui-packages instead of bin\packages release.maui.yaml created that builds the new csla.mauil.build.sln and then pushes the nuget packages found under bin\maui-packages
|
@rockfordlhotka I have also noticed that the ci build uses csla.test.sln. This solution did not before, nor does it now, contain a reference to csla.xaml.maui.csproj. This means that not only does this project not have any unit tests (which may be fine), but it also does not build as a part of a ci build (which also may be fine). It's probably OK as there is no code directly in it (only code from csla.xaml.shared). But if code ever were added to that project as things stand now, it would never go through any CI verification. |
|
iirc, we don't include the MAUI projects in the CI build because that requires a Windows runner and also requires installation of the MAUI workload on each run - which consumes build minutes. Now that we have a separate release for MAUI, I think we could consider adding a new CI build action to detect when changes have happened within the MAUI subtree and to then run a CI build using a Windows runner and install the workload. That would be a good improvement - for a different PR. |
…maui instead of maui-packages.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
#4385
NOTE: The only way to fully test this end to end would be via a release.