Implement getFileDataURI for binary files #1211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanzhong
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for reading binary files by implementing a getFileDataURI function that returns base64-encoded file content. It integrates changes from the MarkEdit-api repository (v0.19.0) by adding a base64Encoded parameter to the existing getFileContent method.
Changes:
- Enhanced
getFileContentto support both text and base64-encoded output via a new boolean parameter - Added
getFileDataURIfunction as a convenience wrapper for base64-encoded file reading - Updated dependency to markedit-api v0.19.0
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| MarkEditKit/Sources/Bridge/Native/Modules/EditorModuleAPI.swift | Added base64Encoded parameter to getFileContent method and implemented conditional encoding logic |
| MarkEditKit/Sources/Bridge/Native/Generated/NativeModuleAPI.swift | Updated protocol signature and bridge message structure to support the new parameter |
| CoreEditor/src/bridge/native/api.ts | Updated TypeScript interface to include base64Encoded parameter in method signature |
| CoreEditor/src/api/files.ts | Modified getFileContent to explicitly pass base64Encoded: false and added new getFileDataURI function |
| CoreEditor/src/api/modules.ts | Added import and export for the new getFileDataURI function |
| CoreEditor/package.json | Updated markedit-api dependency from v0.18.0 to v0.19.0 |
| CoreEditor/yarn.lock | Updated lockfile to reflect new markedit-api version and checksum |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates MarkEdit-app/MarkEdit-api@6268b58