Use 'C'-language variables for checking compiler compatibility in Midl.cmake #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the check that enforces an MSVC compiler or MSVC compiler front-end - the code was checking the
CMAKE_CXX_COMPILER_IDorCMAKE_CXX_COMPILER_FRONTEND_VARIANT(i.e.CXX), but consumed the, say,CMAKE_C_COMPILER. Since midl.exe uses the C compiler, the '' variables should beC-based, and notCXX-based. Given that theCMAKE_C_COMPILER-value was being used, theClanguage must've be enabled; this change would remove the necessity to enable theCXXlanguage.