Add json schema to compatible models #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
July 8, 2025 10:20
for more information, see https://pre-commit.ci
…eedback into add-json-schema
Rolland-He
reviewed
Jul 9, 2025
Collaborator
Rolland-He
left a comment
Rolland-He
left a comment
There was a problem hiding this comment.
Hi @wkukka1 , good work! I've left one inline comment.
| self.model = self.client.beta.assistants.create( | ||
| name="Markus LLM model", | ||
| model="gpt-4-turbo", | ||
| model="gpt-4o-mini", |
Collaborator
There was a problem hiding this comment.
Not sure whether this is related to the PR.
Collaborator
Author
There was a problem hiding this comment.
I got approval from @david-yz-liu to do this since the gpt-4-turbo model doesn't support structured responses using the response_format arg.
david-yz-liu
reviewed
Jul 9, 2025
| Optional[Tuple[str, str]]: A tuple containing the prompt and the model's response, | ||
| or None if the response was invalid. | ||
| """ | ||
| schema = None |
Contributor
There was a problem hiding this comment.
Let's keep the code structure consistent with the other classes (if-else, etc.) Also keep the open call the same, with the utf-8 encoding
| response = self._call_openai(prompt, system_instructions) | ||
| if json_schema: | ||
| schema_path = Path(json_schema) | ||
| if not schema_path.exists(): |
Contributor
There was a problem hiding this comment.
This is a nice check; please add this to all of the classes.
david-yz-liu
approved these changes
Jul 10, 2025
wkukka1
added a commit
to wkukka1/ai-autograding-feedback
that referenced
this pull request
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates:
--json_schemaarg to cliOpenAIModel,OpenAIVectorModel,Codellama,DeepSeek-R1, andDeepSeek-v3to use json schema if supplied