Update question extraction #32
Conversation
This reverts commit e320a00.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Rolland-He
left a comment
Rolland-He
left a comment
There was a problem hiding this comment.
Hi @wkukka1 , nice work!
…tograding-feedback into update-question-extraction
for more information, see https://pre-commit.ci
|
|
||
| if not task_found: | ||
| print(f"Task {question_num} not found in any assignment file.") | ||
| print(f"Task {question} not found in any assignment file.") |
There was a problem hiding this comment.
since this is no longer a number, put quotes around {question}
| from typing import Any, Dict, List, Optional | ||
|
|
||
|
|
||
| def extract_images(input_notebook_path: os.PathLike, output_directory: os.PathLike, output_name: str): |
There was a problem hiding this comment.
add a return type annotation here (just noticed it was missing, but now it's changed)
|
|
||
| qp = Path(qmd_path) | ||
| if not qp.exists(): | ||
| raise FileNotFoundError(f"QMD/RMD file not found: {qmd_path}") |
There was a problem hiding this comment.
remove the "/RMD" part
| start_line = 0 | ||
| fence_kind = None # "```" or "~~~" | ||
|
|
||
| while i < len(lines): |
There was a problem hiding this comment.
Since this is a case where i should always be incremented, it's better to use for i, raw in enumerate(lines)
pyproject.toml
Outdated
| "pillow", | ||
| "PyPDF2", | ||
| "requests", | ||
| "matplotlib" |
There was a problem hiding this comment.
keep the dependencies in alphabetical order
| from typing import List, Optional | ||
| from typing import Any, Dict, List, Optional, Tuple | ||
|
|
||
| import fitz |
There was a problem hiding this comment.
Seems like this is an old name (https://pymupdf.readthedocs.io/en/latest/tutorial.html). The package should also be added to the project dependencies
…tograding-feedback into update-question-extraction
| cur = [] | ||
| start_line = i | ||
| fence_kind = "~~~" if line.strip().startswith("~~~") else "```" | ||
| i += 1 |
There was a problem hiding this comment.
As a result of switching to a for loop, the i += 1 statements are no longer necessary
david-yz-liu
left a comment
david-yz-liu
left a comment
There was a problem hiding this comment.
Thank you, @wkukka1!
3 participants
Updates
--questionargument.fitz(PyMuPDF) to extract the table of contents and locate headings/questions.QMDfiles, currently limited to Python code blocks.question_numwithquestion