-
Notifications
You must be signed in to change notification settings - Fork 116
Make Playwright host configurable #4010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for the contribution. Currently our CI is broken because of bug in statuschecker. I will try to fix CI this week and I will rerun your PR when CI is fixed. By a quick look your code and need looks OK, but I will take a better look when I am able to use bigger screen instead of a mobile. @allcontributors please add @dean4711 for code. |
I've put up a pull request to add @dean4711! 🎉 |
This fixes #4012 |
Looks like there is a bug somewhere and bunch of tests fail. Could you take a look? |
Hi are you interested to see what causes this to fail or should we close the PR? |
Hi @aaltat, I've fixed the merge conflicts. |
@aaltat Some of the build jobs still failing. I'm not sure if the error is a result of my changes. Can you give me a hint? |
There is failure in unit tests, can you see same error also locally? |
I was finally able to fix the tests. Very obvious error in the end. |
Good that you got it resolved. Could you also resolve the conflict with the main and then we could merge the PR |
I'm sorry. Which conflict with the main do you mean? |
I didn’t look, but GitHub says that there is merge conflict and it prevents the merge to main branch. If you fetch changes from this repository main and try to rebase, git shows you the conflict |
Using robotframework-browser within a VS Code devcontainer on a macOS host with --network host is not possible, since the binding when starting Playwright fails. However, when using 0.0.0.0 as host everything works as expected.
Therefore, this merge request makes the host when starting the playwright process configurable.
Fixes #4012