fix: implement validation and fund transfer for release_partial - #276
Merged
Conversation
Closed
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
release_partial, which was previously a public no-op that returnedOk(())without releasing funds, validating the escrow, checking authorization, updating state, or emitting a release event.The implementation now makes
release_partialbehave consistently with the existing release flows.What changed
Implemented buyer authorization for
release_partialAdded escrow existence validation
Added amount validation for:
amount <= 0amount > remaining escrow balanceReused the existing fee calculation helper
Transferred the requested partial amount
Persisted the reduced escrow balance
Transitions the escrow to
Releasedwhen the remaining balance reaches zeroEmits
FundsReleasedEventUpdates total released amount and release count
Preserved the existing
partial_releases_enabledfeature-flag checkAdded documentation for
release_partial, including its arguments and errorsDefined and tested interaction between
release_partialandrelease_itemto prevent over-releaseCorrected the stale README claim regarding
refund_escrowAudited the remaining public entry points for unused parameters/silent no-op implementations
Tests
Added coverage for the enabled
release_partialpath, including:EscrowNotFoundInvalidEscrowAmountInvalidEscrowAmountUnauthorizedrelease_itemIssue
Closes #271
CI
All required CI checks must pass: