Skip to content

Conversation

@classicrocker883
Copy link
Contributor

@classicrocker883 classicrocker883 commented Nov 21, 2025

Description

Changing SERIAL_ECHO* to DEBUG_ECHO*
Add option to disable serial output for UBL in ubl_G29.cpp results in saving ~1976 bytes (previously 1432) using new DISABLE_UBL_SERIAL_CHITCHAT

  • Also adds DEBUG_ECHO_SP to debug_out.h

Probably some serial echo could be kept, after all DEBUG_LEVELING_FEATURE is "detailed logging of G28, G29, M48, etc.".

Tip

Thoughts?
Comments?
Suggestions?
Changes?

Requirements

Benefits

  • Keep original integrity
  • Save flash if needed
  • Fix/improve on DEBUG_LEVELING_FEATURE / VALIDATE_MESH_TILT

Configurations

Related Issues

there are multiple errors when VALIDATE_MESH_TILT is enabled (in ubl_g29.cpp) - such as gotz and probe_pt are undefined.
this PR does fix that by rearranging the values

@ellensp
Copy link
Contributor

ellensp commented Dec 4, 2025

Many advanced users do not use displays, they are far to limiting.
This PR looks like it makes normal command line use of ubl_G29 without a screen impossible.
Many of these are not debugging they are basic operations for serial gcode operation.

Now if you where to add a feature to advanced eg "DISABLE_UBL_SERIAL_CHITCHAT" or something like that I think this would be a better option than redefining it all as debugging. the user gets to choose if they want it or not.

@classicrocker883
Copy link
Contributor Author

so far reverted the DEBUG from SERIAL to have DISABLE_UBL_SERIAL_CHITCHAT option instead.

one thing I found is VALIDATE_MESH_TILT could not work as is. see Issues in description.
I made changes to rearrange/fix it.

@classicrocker883 classicrocker883 marked this pull request as ready for review December 21, 2025 04:23
@classicrocker883
Copy link
Contributor Author

all seems well, just not sure if DEBUG_SYNCHRONIZE() should be used in place of planner.synchronize()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants