-
-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Save flash - use DEBUG for SERIAL (UBL) #28184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bugfix-2.1.x
Are you sure you want to change the base?
Save flash - use DEBUG for SERIAL (UBL) #28184
Conversation
|
Many advanced users do not use displays, they are far to limiting. Now if you where to add a feature to advanced eg "DISABLE_UBL_SERIAL_CHITCHAT" or something like that I think this would be a better option than redefining it all as debugging. the user gets to choose if they want it or not. |
|
so far reverted the DEBUG from SERIAL to have one thing I found is |
|
all seems well, just not sure if |
Description
ChangingSERIAL_ECHO*toDEBUG_ECHO*Add option to disable serial output for UBL in ubl_G29.cpp results in saving ~1976 bytes (previously 1432) using new
DISABLE_UBL_SERIAL_CHITCHATDEBUG_ECHO_SPto debug_out.hProbably some serial echo could be kept, after allDEBUG_LEVELING_FEATUREis "detailed logging of G28, G29, M48, etc.".Tip
Thoughts?
Comments?
Suggestions?
Changes?
Requirements
Benefits
DEBUG_LEVELING_FEATURE/VALIDATE_MESH_TILTConfigurations
Related Issues
there are multiple errors when
VALIDATE_MESH_TILTis enabled (in ubl_g29.cpp) - such asgotzandprobe_ptare undefined.this PR does fix that by rearranging the values