-
-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Add gcode preview to TFT_COLOR_UI #28189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bugfix-2.1.x
Are you sure you want to change the base?
Add gcode preview to TFT_COLOR_UI #28189
Conversation
ee90bdc to
bde33cd
Compare
13bc612 to
fb27eb9
Compare
|
Looks cool, and overall everything is clean and styled. We can put third party headings on any contributed files, like the decoders, with a smaller Marlin "This file is part of..." heading instead of the whole GPL precursor. In general, such a lesser header could be placed on all minimally-modified library files to emphasize their own (often more open) licenses. The image reminds me that we need to fix up that "remaining time" estimate. It's been bugging me. The remaining time estimate starts early in the print before calibration and heating, but it should wait for the first printing move and subtract all the previous time and the SD Position for the rest of the estimate. This will make the estimation that uses the file position a little bit closer to true, and get rid of the useless estimation before the print gets started. Other heuristic adjustments can be made, but of course letting the slicer provide the remaining time estimate will always be best. |
Description
Initial rough draft of adding gcode preview to TFT_COLOR_UI.
Only been tested in the SIM (See example Config below)
New Configuration_adv.h options
//#define HAS_GCODE_PREVIEW 1 // Preview G-code model thumbnail
//#define HAS_JPEG_DECODER 1 // Enable JPEG thumbnail decoding
//#define HAS_PNG_DECODER 1 // Enable PNG thumbnail decoding
//#define HAS_QOI_DECODER 1 // Enable QOI thumbnail decoding
I have only implemented basic functionality. decoding and displaying of the preview
All resolution screens need cleaned up and made pretty.
Very much a work in progress.
eg
Requirements
TFT_COLOR_UI and SDSUPPORT
Example Config files
Sim example Configuration.zip
Benefits
Gives the user a visual display of the gcode preview file in the gcode they have selected.
Related Issues