add real availableForWrite to LPC176x - #28411
Open
ellensp wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Under LPC176x marlin availableForWrite always returned TX_BUFFER_SIZE (a static define)
This is not a true value for the available bytes, and if TX_BUFFER_SIZE should be set to 256 it fails to build as it can't be stored in a uint8_t
further
#define LCD_SERIAL_TX_BUFFER_FREE() LCD_SERIAL.available()is not correctAdded missing fuction to p3p/pio-framework-arduino-lpc176x#56 (awating review)
And updated Marlin/src/HAL/LPC1768/MarlinSerial.h to use it
Requirements
DGUS_LCD_UI_RELOADED and DGUS_LCD_UI_E3S1PRO uses this LCD_SERIAL_TX_BUFFER_FREE define
Benefits
Real availableForWrite
Related Issues