Enable Z-Probe for Lerdge K board#28461
Open
franz-ap wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A tiny change, that enables the Z-Probe pin of Lerdge K boards.
Problem:
"#define Z_MIN_PROBE_PIN" was commented out in Marlin/src/pins/stm32f4/pins_LERDGE_K.h, causing error "Z_MIN_PROBE_PIN must be defined if Z_MIN_PROBE_USES_Z_MIN_ENDSTOP_PIN is not enabled." in SanityCheck.h
In the history of file pins_LERDGE_K.h I saw, that it was like that since the beginning, only the pin name was corrected after a while. So, probably it was not commented out because of a problem. It seems, that I am simply the first one, who wants to use this feature on a Lerdge K board.
Tests:
I did not provide a test case in buildroot/tests because that would require real hardware.
So, I ran the tests on my Lerdge K board: attached wires to the "Probe" connector and sent command M119 via USB serial.
Successfully tested with branches Marlin bugfix-2.1.x and Marlin 2.1.2.7.
Requirements
Hardware:
Benefits
Marlin Firmware can be built for a Lerdge K board with Z-Probe enabled.
Configurations
config_for_2.1.2.7.zip
config_for_bugfix-2.1.x.zip
Build command:
platformio run -e LERDGEK_usb_flash_drive
Related Issues
None found.