Delta printers only - Detect/correct condition when only E movement should occur#28482
Open
Bob-the-Kuhn wants to merge 2 commits into
Open
Delta printers only - Detect/correct condition when only E movement should occur#28482Bob-the-Kuhn wants to merge 2 commits into
Bob-the-Kuhn wants to merge 2 commits into
Conversation
On a delta printer when the X, Y, or Z axis is/are invalid, issuing an E only command will result in negative Z movement of the head until it crashes into the bed. This code detects the condition and then modifieds the Z destination so that no Z movement occurs.
1. fix white space typo (new line 92) 2. Add in correction (line 271) - I expect this is coming from another ECO as it showed up after pulling the latest branch and before my ECO was submitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a delta printer, when the X, Y, or Z axis is/are invalid, issuing an E only command will result in negative Z movement of the head until it crashes into the bed.
This code detects the condition and then modifies the Z destination so that no Z movement occurs.
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
Immediately before a print, I like to extrude filament until a nice thread comes out of the nozzle. Sometimes I forget to see if the steppers have timed out before issuing the command. If I issue the command when X, Y and/or Z are invalid (values blinking on LCD), then the head starts descending and will crash into the bed unless I hit RESET or power cycle.
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
I have not been able to identify the root cause of this issue. I expect this should be addressed in planner.cpp during the creation of "cart_dist_mm" but I couldn't figure out a change that would compile.
I expect a better solution will be proposed. I have no problems with that.
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
My setup: