-
Notifications
You must be signed in to change notification settings - Fork 381
Web: Updates for Table and Column Lineage #2725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for peppy-sprite-186812 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2725 +/- ##
=========================================
Coverage 84.45% 84.45%
Complexity 1416 1416
=========================================
Files 251 251
Lines 6447 6447
Branches 291 291
=========================================
Hits 5445 5445
Misses 850 850
Partials 152 152 ☔ View full report in Codecov by Sentry. |
# Conflicts: # web/src/components/datasets/DatasetDetailPage.tsx # web/src/store/sagas/index.ts
|
Hey have we got rid of the "full" switch to just show critical path? I know we have the minimap but that feature was massively helpful for large graphs. |
I missed this one in the migration, but I added it back in. 😄 |
Yeah that's looking good - I guess do we need to repeat this info? Not overly bothered either way as its not impacting anything. That other PR I have open should sort out this part and make it a nicer fit with the new UI. |
|
@davidsharp7 Yes, I'm just going to repeat the tags for now. I think it doesn't really need it's own tab in the layout in the longer term. I also added some cleanup to this in the subsequent PR #2727. |
|
Hey @phixMe , the update looks amazing 🚀 I gave it a test and sent some simple lineage events from Airflow DAG. Job page looks good: Also, if I go to column lineage view I see this: and clicking anything on the graph results in: Happy to provide more details if needed 😄 |
|
@pawel-big-lebowski Looks like some encoding issues on the namespaces as far as I can tell. I'll try out your events and hopefully get that resolved. |
|
@JDarDagran I'm expecting these to be non-null at the moment. I can remove the null data nodes, but that still looks wrong. |
JDarDagran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested some cases and it works excellent! Great work @phixMe!
wslulciuc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New lineage layout rendering engine, column-level lineage support, and so much more to kick off 2024! Amazing work, @phixMe 💯 🥇








Problem
We currently have a feature gap for column lineage where we don't have a display for it. In order to correctly display this we needed to have something to handle nested graphs so that columns can be nested under tables.
This PR both creates a new page for column lineage and an updated view for lineage with a common set of shared principles.
Solution
Feature Set
Technical
Marquez.Lineage.mov
One-line summary:
New views for both table and column lineage with shared new engine. Marks column lineage as
betafor preview.Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)