Skip to content

Conversation

@wslulciuc
Copy link
Member

@wslulciuc wslulciuc commented Oct 25, 2024

A long over due bug fix for Dataset.currentVersionUuid incorrectly mapped to DatasetVersion.version instead of DatasetVersion.uuid.

Fixes #1883

@boring-cyborg boring-cyborg bot added the api API layer changes label Oct 25, 2024
@netlify
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 342b65e
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/671c10ddf68fed0008aab83c

@wslulciuc wslulciuc added this to the 0.51.0 milestone Oct 25, 2024
@wslulciuc wslulciuc requested a review from phixMe October 25, 2024 21:42
@wslulciuc wslulciuc marked this pull request as ready for review October 25, 2024 21:42
@codecov
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (3b43a3e) to head (342b65e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2954   +/-   ##
=========================================
  Coverage     81.16%   81.16%           
  Complexity     1506     1506           
=========================================
  Files           268      268           
  Lines          7363     7363           
  Branches        329      329           
=========================================
  Hits           5976     5976           
  Misses         1226     1226           
  Partials        161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, Looks good!

@wslulciuc wslulciuc merged commit 5a33b2f into main Oct 25, 2024
@wslulciuc wslulciuc deleted the bug/use-dataset-version-uuid-for-version branch October 25, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api API layer changes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Dataset currentVersion not in Dataset Versions Listing

3 participants