Skip to content

make 'pause after song' work#3565

Open
Glench wants to merge 1 commit intoMarshallOfSound:masterfrom
Glench:master
Open

make 'pause after song' work#3565
Glench wants to merge 1 commit intoMarshallOfSound:masterfrom
Glench:master

Conversation

@Glench
Copy link
Copy Markdown

@Glench Glench commented May 18, 2019

fixes #3383

There may be a further issue with change:track being fired twice that warrants looking into.

@welcome
Copy link
Copy Markdown

welcome bot commented May 18, 2019

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line: - Run npm run lint locally to catch formatting errors earlier. - Include tests when adding/changing behavior. - Include screenshots and animated GIFs whenever possible. - If you added new translation strings ensure that you have added empty strings for all languages - If you added new functionality or modified existing functionality please ensure it is tested

@Glench
Copy link
Copy Markdown
Author

Glench commented May 18, 2019

I opened an issue on the potential change:track bug here: gmusic-utils/gmusic.js#24

@Glench
Copy link
Copy Markdown
Author

Glench commented Aug 6, 2019

@MarshallOfSound any word on getting this merged?

@JustACuteGirlLookingForAManToFixHerBugs
Copy link
Copy Markdown

Hopefully this can be revived

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Pause after this song" doesn't seem to be working

4 participants