Add seek and scan predicate summary details to plans - #16
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new statement-summary surface for seek/scan predicate information, extending Core parsing to extract predicate/seek predicate text and exposing it in the Blazor UI as a dedicated summary table.
Changes:
- Introduced
SeekScanPredicateEntryand extendedStatementPlanSummaryto carry seek/scan predicate summaries. - Updated
ShowplanParserto collect predicate + seek predicate details for seek/scan operators with object context (db/schema/table/index). - Rendered the new summary data in
Home.razorwith matching table styling; updated/added Core tests accordingly.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/MSSQLPlanViewer.Core.Tests/TestPlanFactory.cs | Updated test plan factory summaries to include empty seek/scan predicate entries. |
| tests/MSSQLPlanViewer.Core.Tests/ShowplanParserTests.cs | Added coverage asserting predicate + seek predicate extraction into statement summaries. |
| tests/MSSQLPlanViewer.Core.Tests/PlanProjectionTests.cs | Updated summary construction in projection tests to account for the new summary field. |
| tests/MSSQLPlanViewer.Core.Tests/PlanComparisonServiceTests.cs | Updated statement summary creation to include empty seek/scan predicate entries. |
| src/MSSQLPlanViewer.Web/Components/Pages/Home.razor.css | Added styling for the seek/scan predicate summary table and predicate cell wrapping. |
| src/MSSQLPlanViewer.Web/Components/Pages/Home.razor.cs | Added helper for formatting table name display for predicate entries. |
| src/MSSQLPlanViewer.Web/Components/Pages/Home.razor | Added a new “Seek/Scan predicates” summary table wired to statement summary data and node selection. |
| src/MSSQLPlanViewer.Core/Parsing/ShowplanParser.cs | Collected seek/scan predicate entries from parsed nodes and attached them to statement summaries. |
| src/MSSQLPlanViewer.Core/Models/StatementPlanSummary.cs | Extended the statement summary model with SeekScanPredicateEntries. |
| src/MSSQLPlanViewer.Core/Models/SeekScanPredicateEntry.cs | Added the new model capturing node/object context plus predicate/seek predicate text. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SeekScanPredicateEntrymodel to capture predicate details for seek and scan operators.PredicateandSeek predicatevalues into statement summaries.Testing