ensure we don't run the reconciler for resources that are being deleted#42
Merged
doy-materialize merged 2 commits intomainfrom Dec 17, 2025
Merged
ensure we don't run the reconciler for resources that are being deleted#42doy-materialize merged 2 commits intomainfrom
doy-materialize merged 2 commits intomainfrom
Conversation
alex-hunt-materialize
approved these changes
Dec 17, 2025
alex-hunt-materialize
requested changes
Dec 17, 2025
Contributor
alex-hunt-materialize
left a comment
alex-hunt-materialize
left a comment
There was a problem hiding this comment.
We should bump the version and actually release this.
Collaborator
Author
|
updated |
alex-hunt-materialize
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if we have a finalizer, the
finalizerfunction automatically routes events to eitherapplyorcleanupbased on whether the resource is being deleted, but if we don't, we need to implement that ourselves.