Merged
Conversation
alex-hunt-materialize
force-pushed
the
test_improvements
branch
from
8a3b8a4 to
ab8a18b
Compare
jubrad
approved these changes
Apr 7, 2026
Collaborator
jubrad
left a comment
jubrad
left a comment
There was a problem hiding this comment.
Looks good, one question on shelling out for s3 commands
Comment on lines
+303
to
+312
| println!("Deleting remote state from {prefix}"); | ||
| let mut cmd = Command::new("aws"); | ||
| cmd.args([ | ||
| "s3", | ||
| "rm", | ||
| &prefix, | ||
| "--recursive", | ||
| "--region", | ||
| &backend.region, | ||
| ]); |
Collaborator
There was a problem hiding this comment.
why not use an aws sdk for this?
Contributor
Author
There was a problem hiding this comment.
Because claude wrote it and I didn't think of it. I'll follow up with another PR to change that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is easier to review each commit individually.