Add OEL image support to Ory Kratos and Hydra modules#186
Open
bobbyiliev wants to merge 2 commits intomainfrom
Open
Add OEL image support to Ory Kratos and Hydra modules#186bobbyiliev wants to merge 2 commits intomainfrom
bobbyiliev wants to merge 2 commits intomainfrom
Conversation
Contributor
alex-hunt-materialize
left a comment
alex-hunt-materialize
left a comment
There was a problem hiding this comment.
This all looks fine, but doesn't match my design doc https://github.com/MaterializeInc/cloud/pull/12390
Collaborator
Author
Yep, this is intentionally ahead of the design doc, the module changes here just add image_repository, image_tag, and image_pull_secrets variables, which are needed regardless of the auth mechanism. I've tested OEL images end-to-end on all three clouds using a temporary GCP key file approach to make sure it all works together. Will adapt to match the design doc (JWT parsing, secret creation inside modules) in a follow-up once we have it approved! Should be a straightforward swap on top of this 🤞 |
alex-hunt-materialize
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding those vars to ory-kratos and ory-hydra modules to support Ory Enterprise License deployments with private registry images.