docs: google terraform storage bucket versioning#32041
Merged
kay-kim merged 2 commits intoMaterializeInc:self-managed-docs/v25.1from Apr 16, 2025
Merged
docs: google terraform storage bucket versioning#32041kay-kim merged 2 commits intoMaterializeInc:self-managed-docs/v25.1from
kay-kim merged 2 commits intoMaterializeInc:self-managed-docs/v25.1from
Conversation
kay-kim
commented
Mar 28, 2025
| rows: | ||
| - "Terraform version": | | ||
|
|
||
|
|
Contributor
Author
There was a problem hiding this comment.
kay-kim
force-pushed
the
docs-google-terraform-next
branch
from
47336b7 to
1884b23
Compare
kay-kim
commented
Mar 28, 2025
|
|
||
| {{</ tabs >}} | ||
|
|
||
| ## Storage bucket versioning |
Contributor
Author
There was a problem hiding this comment.
kay-kim
force-pushed
the
docs-google-terraform-next
branch
from
1884b23 to
ee11eb7
Compare
kay-kim
force-pushed
the
docs-google-terraform-next
branch
from
ee11eb7 to
28b10fb
Compare
jubrad
reviewed
Apr 4, 2025
Comment on lines
+29
to
+33
| Starting in v0.2.1 of Materialize on GCP Terraform, storage bucket versioning is | ||
| disabled to facilitate cleanup of resources during testing. When running in | ||
| production, versioning should be turned on with a sufficient TTL to meet any | ||
| data-recovery requirements. | ||
|
|
Contributor
There was a problem hiding this comment.
In the referenced pr I did decide to enable versioning with a TTL of 7 days for non active versions, but make this configurable. This is a middle ground that more easily allows one to test without versioning enabled while maintaining the preferred production setting.
Contributor
Author
There was a problem hiding this comment.
👍 will do a patch tomorrow.
Contributor
Author
There was a problem hiding this comment.
So ... apparently, "tomorrow" is "next week" 😄 .
In any case, it's still disabled, yes? (I see the default is false) it's just that the ttl default value is set to 7.
Contributor
There was a problem hiding this comment.
oh yeah, sorry I think I waffled on this a few times thanks for reading closely!!!
kay-kim
force-pushed
the
docs-google-terraform-next
branch
from
28b10fb to
ec6d628
Compare
jubrad
approved these changes
Apr 16, 2025
kay-kim
merged commit 614bc14
into
MaterializeInc:self-managed-docs/v25.1
8 checks passed
kay-kim
added a commit
to kay-kim/materialize
that referenced
this pull request
Jun 6, 2025
kay-kim
added a commit
that referenced
this pull request
Jun 6, 2025
kay-kim
added a commit
to kay-kim/materialize
that referenced
this pull request
Jun 9, 2025
kay-kim
added a commit
to kay-kim/materialize
that referenced
this pull request
Jun 9, 2025
kay-kim
added a commit
that referenced
this pull request
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reference docs update per MaterializeInc/terraform-google-materialize#22