Skip to content

Conversation

@kay-kim
Copy link
Contributor

@kay-kim kay-kim commented May 5, 2025

  • Commit 1: Added create table from source syntax for db sources. Part 2 will include kafka sources ... but since the changes were starting to get large, thought I'd break it up into multiple parts (such as to add examples, update concepts/details, etc. ...) to make the reviews easier. Commit 2 will include kafka source syntax. (depending on when things get reviewed and merged, as work progresses, will either add to this PR or have separate PR)
  • Commit 2: Added syntax for kafka sources
  • Commit 3: lint error - spacing
  • Commit 4: webhook syntax

Will merge all the docs prep work into the docs-prep-source-versioning branch.

https://preview.materialize.com/materialize/32413/sql/create-table/

@kay-kim kay-kim requested a review from a team as a code owner May 5, 2025 18:48
overflow-x: scroll;

padding-bottom: var(--xx-small);
overflow-x: auto;
Copy link
Contributor Author

@kay-kim kay-kim May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some housecleaning for tabs. Can ignore.

navTabs.append(`<li><a href="#${id}-t${idx}">${title}</a></li>`);
});
});
document.addEventListener("DOMContentLoaded", function () {
Copy link
Contributor Author

@kay-kim kay-kim May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some housecleaning for tabs. Can ignore.

Basically, I just asked chatgpt to changed from jquery to regular js and allow for nested tabs.

@kay-kim kay-kim force-pushed the docs-create-table-prep-source-versioning-pt1 branch from 94141b7 to 1327b64 Compare May 5, 2025 19:00
[WITH (
TEXT COLUMNS (<fq_column_name> [, ...])
| EXCLUDE COLUMNS (<fq_column_name> [, ...])
[, ...]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checking that db source tables don't support WITH (RETAIN HISTORY...) -- at least, using environmentd v0.130.11


`CREATE TABLE` defines a table that is persisted in durable storage and can be
written to, updated and seamlessly joined with other tables, views or sources.
`CREATE TABLE` defines a table that is persisted in durable storage. In
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kay-kim kay-kim requested a review from petrosagg May 5, 2025 19:14
@kay-kim kay-kim force-pushed the docs-create-table-prep-source-versioning-pt1 branch 6 times, most recently from d710457 to 25a9a85 Compare May 19, 2025 15:03
@kay-kim kay-kim force-pushed the docs-create-table-prep-source-versioning-pt1 branch 3 times, most recently from cb558b9 to 54ed898 Compare June 4, 2025 00:40
@kay-kim kay-kim force-pushed the docs-create-table-prep-source-versioning-pt1 branch from 54ed898 to 63efef0 Compare June 16, 2025 14:52
@kay-kim kay-kim force-pushed the docs-create-table-prep-source-versioning-pt1 branch from 63efef0 to 962b684 Compare June 23, 2025 15:04
@kay-kim kay-kim force-pushed the docs-create-table-prep-source-versioning-pt1 branch from d0e950b to 9b8494a Compare July 7, 2025 18:14
@kay-kim kay-kim force-pushed the docs-create-table-prep-source-versioning-pt1 branch from 9b8494a to 9794cba Compare August 18, 2025 19:45
@kay-kim
Copy link
Contributor Author

kay-kim commented Aug 18, 2025

closing as out of sync.

@kay-kim kay-kim closed this Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant