-
Notifications
You must be signed in to change notification settings - Fork 472
docs: add in-progress note w.r.t. supporting upstream table schema ch… #32436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add in-progress note w.r.t. supporting upstream table schema ch… #32436
Conversation
@@ -259,7 +261,7 @@ The specified columns will be treated as `text`, and will thus not offer the | |||
expected MySQL type features. For any unsupported data types not listed above, | |||
use the [`EXCLUDE COLUMNS`](#excluding-columns) option. | |||
|
|||
##### Truncation | |||
### Truncation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to double-check this. Was under the impression that subsources (i.e., tables replicated into Materialize) aren't writable (insert/update/delete) by the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ... heh heh ... I guess this meant truncating on the upstream side ... not within Materialize.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page will be updated as part of the source versioning docs work.
@@ -206,11 +206,13 @@ debugging related issues, see [Troubleshooting](/ops/troubleshooting/). | |||
|
|||
## Known limitations | |||
|
|||
##### Schema changes | |||
### Schema changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
##### Schema changes | ||
### Schema changes | ||
|
||
{{< include-md file="shared-content/schema-changes-in-progress.md" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -264,7 +266,7 @@ example: | |||
* [`money`]: the resulting `text` value cannot be cast back to e.g. `numeric`, | |||
since PostgreSQL adds typical currency formatting to the output. | |||
|
|||
##### Truncation | |||
### Truncation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto w.r.t. deleting or truncating a subsource table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto w.r.t truncating on the upstream side ... not within Materialize.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eh ... this page will be updated as part of the source versioning docs work.
@@ -431,6 +433,8 @@ CREATE SOURCE mz_source | |||
|
|||
### Handling errors and schema changes | |||
|
|||
{{< include-md file="shared-content/schema-changes-in-progress.md" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -409,6 +411,8 @@ CREATE SOURCE mz_source | |||
|
|||
### Handling errors and schema changes | |||
|
|||
{{< include-md file="shared-content/schema-changes-in-progress.md" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
Work to more smoothly support ddl changes to upstream tables is currently in | ||
progress. The work introduces the ability to re-ingest the same upstream table | ||
under a new schema. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can also put in "and switch over" to the end of the sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and switch over without downtime
36b0d9c
to
6b8c721
Compare
@petrosagg even though you are going to do a survey of https://en.wikipedia.org/wiki/SQL/MED with the potential for us to change the syntax around CREATE TABLE FROM SOURCE, it makes sense to review the doc changes without those changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM - left one comment
…anges