Skip to content

DNM: Check if latest docker version works #32440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/builder/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ RUN \
#
# If you upgrade Docker (Compose) version here, also update it in misc/python/cli/mzcompose.py.
&& mkdir -p /usr/local/lib/docker/cli-plugins \
&& curl -fsSL https://github.com/docker/compose/releases/download/v2.15.1/docker-compose-linux-$ARCH_GCC > /usr/local/lib/docker/cli-plugins/docker-compose \
&& curl -fsSL https://github.com/docker/compose/releases/download/v2.36.0/docker-compose-linux-$ARCH_GCC > /usr/local/lib/docker/cli-plugins/docker-compose \
&& chmod +x /usr/local/lib/docker/cli-plugins/docker-compose \
&& curl -fsSL https://github.com/christian-korneck/docker-pushrm/releases/download/v1.9.0/docker-pushrm_linux_$ARCH_GO > /usr/local/lib/docker/cli-plugins/docker-pushrm \
&& chmod +x /usr/local/lib/docker/cli-plugins/docker-pushrm \
Expand Down
2 changes: 1 addition & 1 deletion misc/python/materialize/cli/mzcompose.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ def load_composition(args: argparse.Namespace) -> Composition:
compose_local_version = Version.parse(
spawn.capture(["docker", "compose", "version", "--short"])
)
compose_ci_version = Version.parse("2.15.1")
compose_ci_version = Version.parse("2.36.0")
if compose_local_version < compose_ci_version:
raise UIError(
f"Your Docker Compose version is {compose_local_version} while the version used in CI is {compose_ci_version}, please upgrade your local Docker Compose version to prevent unexpected breakages.",
Expand Down