storage/pg: only report snapshot size error in strict mode #32441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nightly triggered: https://buildkite.com/materialize/nightly/builds/11984 |
petrosagg
force-pushed
the
snapshot-size-error
branch
from
1eea7fc to
c07cc68
Compare
petrosagg
force-pushed
the
snapshot-size-error
branch
2 times, most recently
from
b3fb9aa to
7747e65
Compare
Our default snapshot size determination strategy is to use the table statistics in pg instead of performing a `SELECT COUNT(*)` on the table. This saves resources from the upstream database since it only reads a couple of rows from the statistics table at the expense of accuracy. This PR silences an error that only makes sense when the `COUNT(*)` strategy is used. Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
force-pushed
the
snapshot-size-error
branch
from
7747e65 to
c6c2802
Compare
teskje
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our default snapshot size determination strategy is to use the table statistics in pg instead of performing a
SELECT COUNT(*)on the table.This saves resources from the upstream database since it only reads a couple of rows from the statistics table at the expense of accuracy.
This PR silences an error that only makes sense when the
COUNT(*)strategy is used.Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.