Skip to content

Conversation

@ggevay
Copy link
Contributor

@ggevay ggevay commented May 12, 2025

Fixes a panic when plan_coerce is called twice on a parameter. This typically happens when there is a function call whose more than one argument involves the same prepared statement.

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ggevay ggevay added the A-ADAPTER Topics related to the ADAPTER layer label May 12, 2025
@ggevay ggevay marked this pull request as ready for review May 12, 2025 10:05
@ggevay ggevay requested a review from a team as a code owner May 12, 2025 10:05
@ggevay ggevay requested a review from aljoscha May 12, 2025 10:05
@ggevay ggevay force-pushed the param-typing-contradiction branch from 31bf0e5 to ddec204 Compare May 12, 2025 12:27
@ggevay ggevay force-pushed the param-typing-contradiction branch from ddec204 to aba9134 Compare May 13, 2025 11:22
@ggevay ggevay merged commit 541c892 into MaterializeInc:main May 14, 2025
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ADAPTER Topics related to the ADAPTER layer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants