update mzcompose to support 2000 object search #32478
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptravers
commented
May 12, 2025
Comment on lines
+1290
to
+1310
| ", ".join( | ||
| ", ".join( | ||
| [ | ||
| f"a{i} STRING", | ||
| f"b{i} STRING", | ||
| f"c{i} STRING", | ||
| f"d{i} STRING[]", | ||
| ] | ||
| ) | ||
| for i in cls.all() | ||
| ) | ||
| });""" | ||
| ) | ||
| print("> INSERT INTO t DEFAULT VALUES;") | ||
| print( | ||
| f"""> CREATE MATERIALIZED VIEW v2 AS SELECT { | ||
| ", ".join( | ||
| f"ARRAY_AGG(a{i} ORDER BY b1) FILTER (WHERE 's{i}' = ANY(d{i})) AS r{i}" | ||
| for i in cls.all() | ||
| ) | ||
| } FROM t GROUP BY a1;""" | ||
| ", ".join( | ||
| f"ARRAY_AGG(a{i} ORDER BY b1) FILTER (WHERE 's{i}' = ANY(d{i})) AS r{i}" | ||
| for i in cls.all() | ||
| ) | ||
| } FROM t GROUP BY a1;""" |
There was a problem hiding this comment.
ah sorry this is my auto formatter
ptravers
commented
May 12, 2025
Comment on lines
+1291
to
+1298
| ", ".join( | ||
| [ | ||
| f"a{i} STRING", | ||
| f"b{i} STRING", | ||
| f"c{i} STRING", | ||
| f"d{i} STRING[]", | ||
| ] | ||
| ) |
There was a problem hiding this comment.
auto formatter from my editor.
antiguru
requested changes
May 13, 2025
There was a problem hiding this comment.
I don't think this is what we want by default. It should use the crdb consensus because that's what's running in production, but the diff might help you (or anyone else who needs to debug things) to quickly reproduce the scalability issues around postgres sources we've been observing.
|
ah yeah, sorry. I meant to mark this as a draft. just showing the diff that I'm using locally. I don't think it actually works since it exits at 1000 locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://materializeinc.slack.com/archives/C0854GU86HL/p1747081703632959?thread_ts=1746561807.931999&cid=C0854GU86HL
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.