tests: make sqllogictest tests resilient to result ordering #32483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def-
approved these changes
May 13, 2025
There was a problem hiding this comment.
Nightly triggered: https://buildkite.com/materialize/nightly/builds/12004
Tell me if you need any help with finishing this up
aljoscha
force-pushed
the
tests-sqllogictests-resilient-to-ordering
branch
3 times, most recently
from
99492c3 to
1a86413
Compare
At least those that we managed to find by futzing with result ordering as a result of stashed peek responses.
aljoscha
force-pushed
the
tests-sqllogictests-resilient-to-ordering
branch
from
1a86413 to
ee5d332
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A side effect of the work on https://github.com/MaterializeInc/database-issues/issues/9180 is that it can change the ordering of results when no ORDER BY is specified. This is fine according to the SQL standard and all databases say you shouldn't rely on any ordering.
Some of our tests do, however, rely on a specific ordering, which is what this PR changes, as preparation for https://github.com/MaterializeInc/database-issues/issues/9180.
Tips for reviewers
This is a bit tedious to review, but there's no changes to actual database code, so if all the tests still pass I'd say all's good. You still probably want to check my changes to
sqllogictestaround sorting, and spot-check individual test files.