[repr types] Use HIR SQL types in RelationDescs #34454
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As MIR moves to representation types (#34351), we must be careful to compute SQL types while we still have HIR. If we don't we run the risk of confusing clients who expected a
VARCHARcolumn and got aTEXTcolumn. (To be clear: theDatums on the wire will always be the same, but the type metadata might be different. BI tools may get confused.)This PR (with added tests TBD, perhaps at the pgwire level) makes it safe to merge #34350.
Motivation
design doc: MIR typechecking using representation types #27239
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.