Adds global and per ip connection rate limiting #34515
Draft
+271
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a large number of connections per second can overwhelm environmentd impacting work for existing connections. In order to isolate the impact of connection floods while still maintaining a reasonably high max_connections I propose that we add connection rate limiting. This will send a
too many connectionserror to the client which can then retry with backoffs spreading connection requests a bit. This should reduce impact somewhat, however, large CPS floods will still be making TLS connections which may still lead to environmentd health impairment.Adds connection rate limiting through governor handled by burstable quotas added to the pgwire server config. Limits are checked in handle_connection, and controlled by the following system params.
Environmentd must be restarted to update params.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.