docs: correct the partition operations that break publish_via_partition_root - #38432
Merged
Merged
Conversation
…on_root The warning about `publish_via_partition_root = true` listed adding a partition as one of the operations that surfaces problems. Partitions created with `CREATE TABLE ... PARTITION OF` are empty, so they move no data into the root table. Attaching, detaching, and truncating are the operations that add or remove root-table data without emitting CDC events, so list those instead. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HBUT5iCf2hkNY2hEfruLTp
Alphadelta14
approved these changes
Aug 24, 2026
ohbadiah
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Review feedback on #38199: the
publish_via_partition_root = truewarning on the PostgreSQL partitioned tables page listed adding a partition as one of the operations that surfaces problems. That isn't right. Partitions created withCREATE TABLE ... PARTITION OFare always empty, so they move no data into the root table and cause no divergence. Truncating a partition, which does remove root-table data, was missing from the list.Description
Replaces "added, attached, or detached" with "attached, detached, or truncated" in the warning. All three of those are DDL that adds or removes root-table data without emitting CDC events, which is precisely the failure mode the warning describes.
Verification
Docs-only prose change; no code or test surface. The paragraph rewraps to stay within the file's line width.
Generated by Claude Code