console: CNS-38 explain why an interrupted shell command needs a retry - #38610
Open
jdonelson wants to merge 1 commit into
Open
console: CNS-38 explain why an interrupted shell command needs a retry#38610jdonelson wants to merge 1 commit into
jdonelson wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes CNS-38
Instead of simply displaying "Retry" after a disconnection, add an error message.
Description
Investigation revealed that we can mitigate the disconnection problem at its source. This UX improvement is a first step.
Verification
New test case asserting CONNECTION_CLOSED mid-command sets both interrupted and the error. This event had no coverage at all before.
Assert that an interrupted command renders the message and an enabled Retry button, and that a normal command renders neither.
Manually tested with a non-trivial bit of chicanery.