Skip to content

build: don't disable asserts#32

Merged
def- merged 1 commit intomasterfrom
pr-always-assert
Oct 23, 2025
Merged

build: don't disable asserts#32
def- merged 1 commit intomasterfrom
pr-always-assert

Conversation

@def-
Copy link
Copy Markdown

@def- def- commented Oct 22, 2025

see MaterializeInc/materialize#32629

needed to make sure Cargo Release builds don't run into https://github.com/MaterializeInc/database-issues/issues/9313

Cargo always does RelWithDebInfo builds in cmake by default, with Bazel we had Release builds.

@def- def- requested a review from teskje October 22, 2025 09:32
def- added a commit to def-/materialize that referenced this pull request Oct 22, 2025
@def- def- requested a review from petrosagg October 22, 2025 12:16
@def- def- force-pushed the pr-always-assert branch from 4ebbcd8 to 45a2a34 Compare October 23, 2025 08:07
def- added a commit to def-/materialize that referenced this pull request Oct 23, 2025
Copy link
Copy Markdown

@teskje teskje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@def- def- merged commit 3c92c87 into master Oct 23, 2025
0 of 9 checks passed
@def- def- deleted the pr-always-assert branch October 23, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants