Include metrics server install #20
Conversation
kay-kim
left a comment
kay-kim
left a comment
There was a problem hiding this comment.
lgtm - left a comment about the terraform.tfvars.example
| description = "Whether to install the metrics-server for the Materialize Console" | ||
| type = bool | ||
| default = true | ||
| } |
There was a problem hiding this comment.
Found the correct PR. Same apologies -- a little out of scope, but am noticing that:
-
the
terraform.tfvars.example'smaterialize_instanceshave database_password and are not commented out. (As an FYI -- in the docs, I'm updating the docs now to use a separate tfvars file for the instances, terraform plan -var-file=terraform.tfvars -var-file=mz_instances.tfvars -out my-plan.tfplan`, so that we don't have to worry about commenting and uncommenting.) -
the install_materialize_operator = false in that file (not sure if we want that to be true)
There was a problem hiding this comment.
Ah yes, good catch! I've removed those, I've forgotten them during the initial implementation.
Should be merged after MaterializeInc/terraform-helm-materialize#4 and once
v0.1.2for that helm TF module is released!