fix rollout vars and add balancer resource config args#40
Merged
Conversation
jubrad
requested review from
bobbyiliev and
kay-kim
and removed request for
kay-kim
kay-kim
reviewed
Mar 5, 2025
| balancer_cpu_request = lookup(instance, "balancer_cpu_request", null) | ||
| balancer_memory_request = lookup(instance, "balancer_memory_cpu_request", null) | ||
| balancer_memory_limit = lookup(instance, "balancer_memory_cpu_limit", null) | ||
|
|
Contributor
There was a problem hiding this comment.
Apologies ... usually I don't like to muddy PRs ...
But, the environmentd_version isn't included in our instance handling. Could we patch to include that?
Contributor
There was a problem hiding this comment.
Actually, ignore. I'll have to make changes to the examples/simple in addition to the root main.tf ... so, will make a separate PR to take care of that.
Contributor
There was a problem hiding this comment.
Depending on when this is merged, I might do a patch to this PR, seeing as this touches the 2 files
kay-kim
approved these changes
Mar 5, 2025
jubrad
force-pushed
the
small-fixes-jubrad
branch
from
eacdeb9 to
7a06d09
Compare
…on, environmentd_version for materialize_instances
kay-kim
force-pushed
the
small-fixes-jubrad
branch
from
acb2f99 to
2c37183
Compare
bobbyiliev
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add balancerd resource requirements
blocked by: MaterializeInc/terraform-helm-materialize#21
The simple example didn't have rollout args in the input variable... this seems broken so I added them.