Skip to content

Use explicit region variable instead of data source#26

Merged
bobbyiliev merged 1 commit intomainfrom
bugfix/default-region-var
Mar 18, 2025
Merged

Use explicit region variable instead of data source#26
bobbyiliev merged 1 commit intomainfrom
bugfix/default-region-var

Conversation

@bobbyiliev
Copy link
Copy Markdown
Collaborator

Replacing data.google_client_config.current.region with var.region in the helm_values to fix empty region issue in multi-region GCP projects.

@bobbyiliev bobbyiliev merged commit fceb610 into main Mar 18, 2025
2 checks passed
@bobbyiliev bobbyiliev deleted the bugfix/default-region-var branch March 18, 2025 10:43
@kay-kim
Copy link
Copy Markdown
Contributor

kay-kim commented Mar 31, 2025

QQ: When defining the kubernetes and helm providers, we refer to the google_client_config:
token = data.google_client_config.current.access_token.
In our docs, I can have them declare data "google_client_config" "current" {} at the same time, but wanted to double check that this is okay. It seems preferred since we have them declare it at the same time as when they refer to it. But, wasn't sure if there were any gotchas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants