Add lgalloc support #36
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| #!/bin/bash | ||
| set -xeuo pipefail | ||
|
|
||
| echo "Starting GCP NVMe SSD setup" | ||
|
|
||
| # Install required tools | ||
| if command -v apt-get >/dev/null 2>&1; then | ||
| apt-get update | ||
| apt-get install -y lvm2 | ||
| elif command -v yum >/dev/null 2>&1; then | ||
| yum install -y lvm2 | ||
| else | ||
| echo "No package manager found. Please install required tools manually." | ||
| exit 1 | ||
| fi | ||
|
Comment on lines
+6
to
+15
Contributor
There was a problem hiding this comment. We should definitely version lock this, or if there aren't dependencies, install from a binary.
Collaborator
Author
There was a problem hiding this comment. Just pinned this to a specific version. Regarding the dependencies:
Contributor
There was a problem hiding this comment. This is extremely unlikely to work long-term. If you want to pin it, you need to bake it into an image. The upstream repos will likely not contain that specific version for long.
Collaborator
Author
There was a problem hiding this comment. Sure, but I thought that we did not want to maintain our own image because of security concerns?
Contributor
There was a problem hiding this comment. Well, we can't pin the version this way, and the security concerns don't go away just because you're using someone else's image. We can either:
Collaborator
Author
There was a problem hiding this comment. Just removed the version pin. When I was originally working on that custom container, I got pushback because of concerns that a lot of vulnerability scanner noise could come from bootstrap containers. But if we are all fine with this, I am happy to work on that bootstrap Docker image. |
||
|
|
||
| # Find NVMe devices | ||
| SSD_DEVICE_LIST=() | ||
|
|
||
| # Try the standard GCP pattern first | ||
| devices=$(find /dev/disk/by-id/ -name "google-local-nvme-ssd-*" 2>/dev/null || true) | ||
| if [ -n "$devices" ]; then | ||
| while read -r device; do | ||
| SSD_DEVICE_LIST+=("$device") | ||
| done <<<"$devices" | ||
| fi | ||
|
|
||
| # If no devices found via standard pattern, look for NVMe devices directly | ||
| if [ ${#SSD_DEVICE_LIST[@]} -eq 0 ]; then | ||
| echo "No Local NVMe SSD devices found via standard pattern. Checking direct NVMe devices..." | ||
|
|
||
| for device in /dev/nvme*n*; do | ||
| # Skip if not a block device or if it's a partition | ||
| if [[ -b "$device" && ! "$device" =~ "p"[0-9]+ ]]; then | ||
| # Check if size is approximately 375GB | ||
| size_bytes=$(blockdev --getsize64 $device 2>/dev/null || echo 0) | ||
| # 375GB = approximately 402653184000 bytes | ||
| if ((size_bytes > 400000000000 && size_bytes < 405000000000)); then | ||
| echo "Found potential NVMe local SSD: $device ($((size_bytes / (1024 * 1024 * 1024))) GB)" | ||
| SSD_DEVICE_LIST+=("$device") | ||
| fi | ||
| fi | ||
| done | ||
| fi | ||
|
bobbyiliev marked this conversation as resolved.
Outdated
bobbyiliev marked this conversation as resolved.
Outdated
|
||
|
|
||
| echo "Found ${#SSD_DEVICE_LIST[@]} NVMe SSD devices: ${SSD_DEVICE_LIST[*]:-none}" | ||
|
|
||
| if [ ${#SSD_DEVICE_LIST[@]} -eq 0 ]; then | ||
| echo "No usable NVMe SSD devices found" | ||
| exit 0 | ||
| fi | ||
|
|
||
| # Check if any of the devices are already in use by LVM | ||
| for device in "${SSD_DEVICE_LIST[@]}"; do | ||
| if pvdisplay "$device" &>/dev/null; then | ||
| echo "$device is already part of LVM, skipping setup" | ||
| exit 0 | ||
| fi | ||
| done | ||
|
|
||
| # Create physical volumes | ||
| for device in "${SSD_DEVICE_LIST[@]}"; do | ||
| echo "Creating physical volume on $device" | ||
| pvcreate -f "$device" | ||
| done | ||
|
|
||
| # Create volume group named 'instance-store-vg' | ||
| echo "Creating volume group instance-store-vg" | ||
| vgcreate instance-store-vg "${SSD_DEVICE_LIST[@]}" | ||
|
bobbyiliev marked this conversation as resolved.
|
||
|
|
||
| # Create a logical volume using 100% of the space | ||
| echo "Creating logical volume local-nvme-lv" | ||
| lvcreate -l 100%FREE -n local-nvme-lv instance-store-vg | ||
|
bobbyiliev marked this conversation as resolved.
Outdated
|
||
|
|
||
| # Format the logical volume | ||
| echo "Formatting logical volume with ext4" | ||
| mkfs.ext4 -F /dev/instance-store-vg/local-nvme-lv | ||
|
bobbyiliev marked this conversation as resolved.
Outdated
|
||
|
|
||
| # Mount the logical volume | ||
| mkdir -p /var/openebs || true | ||
| echo "Mounting logical volume to /var/openebs" | ||
| if ! grep -q "/dev/instance-store-vg/local-nvme-lv" /etc/fstab; then | ||
| echo "/dev/instance-store-vg/local-nvme-lv /var/openebs ext4 discard,defaults,nofail 0 2" >>/etc/fstab | ||
| fi | ||
|
|
||
| if ! mount | grep -q "/var/openebs"; then | ||
| mount /var/openebs | ||
| fi | ||
|
|
||
| # Display results | ||
| echo "LVM setup completed:" | ||
| pvs | ||
| vgs | ||
| lvs | ||
| df -h /var/openebs | ||
|
|
||
| echo "NVMe SSD setup completed successfully" | ||
| echo "OpenEBS can use: /var/openebs" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.