Skip to content

Swap follow up improvements part2 #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobbyiliev merged 1 commit into from
Nov 26, 2025
Merged

Swap follow up improvements part2 #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,6 @@ No resources.
| <a name="input_cert_manager_install_timeout"></a> [cert\_manager\_install\_timeout](#input\_cert\_manager\_install\_timeout) | Timeout for installing the cert-manager helm chart, in seconds. | `number` | `300` | no |
| <a name="input_cert_manager_namespace"></a> [cert\_manager\_namespace](#input\_cert\_manager\_namespace) | The name of the namespace in which cert-manager is or will be installed. | `string` | `"cert-manager"` | no |
| <a name="input_database_config"></a> [database\_config](#input\_database\_config) | Cloud SQL configuration | <pre>object({<br/> tier = optional(string, "db-custom-2-4096")<br/> version = optional(string, "POSTGRES_15")<br/> password = string<br/> username = optional(string, "materialize")<br/> db_name = optional(string, "materialize")<br/> })</pre> | n/a | yes |
| <a name="input_disk_setup_image"></a> [disk\_setup\_image](#input\_disk\_setup\_image) | Docker image for the disk setup script | `string` | `"materialize/ephemeral-storage-setup-image:v0.3.4"` | no |
| <a name="input_disk_support_config"></a> [disk\_support\_config](#input\_disk\_support\_config) | Advanced configuration for disk support (only used when enable\_disk\_support = true) | <pre>object({<br/> install_openebs = optional(bool, true)<br/> run_disk_setup_script = optional(bool, true)<br/> local_ssd_count = optional(number, 1)<br/> create_storage_class = optional(bool, true)<br/> openebs_version = optional(string, "4.3.3")<br/> openebs_namespace = optional(string, "openebs")<br/> storage_class_name = optional(string, "openebs-lvm-instance-store-ext4")<br/> })</pre> | `{}` | no |
| <a name="input_enable_disk_support"></a> [enable\_disk\_support](#input\_enable\_disk\_support) | Enable disk support for Materialize using OpenEBS and local SSDs. When enabled, this configures OpenEBS, runs the disk setup script, and creates appropriate storage classes. | `bool` | `true` | no |
| <a name="input_helm_chart"></a> [helm\_chart](#input\_helm\_chart) | Chart name from repository or local path to chart. For local charts, set the path to the chart directory. | `string` | `"materialize-operator"` | no |
| <a name="input_helm_values"></a> [helm\_values](#input\_helm\_values) | Values to pass to the Helm chart | `any` | `{}` | no |
| <a name="input_install_cert_manager"></a> [install\_cert\_manager](#input\_install\_cert\_manager) | Whether to install cert-manager. | `bool` | `true` | no |
Expand Down Expand Up @@ -141,6 +138,15 @@ More advanced TLS support using user-provided CAs or per-Materialize `Issuer`s a

## Upgrade Notes

#### v0.8.0

You must upgrade to at least v0.7.x before upgrading to v0.8.x of this terraform code.

Breaking changes:
* The system node group is renamed and significantly modified, forcing a recreation.
* Both node groups are now locked to consistent configurations and ON\\_DEMAND scheduling.
* OpenEBS is removed, and with it all support for lgalloc, our legacy spill to disk mechanism.

#### v0.7.0

This is an intermediate version to handle some changes that must be applied in stages.
Expand Down
9 changes: 9 additions & 0 deletions docs/footer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,15 @@ More advanced TLS support using user-provided CAs or per-Materialize `Issuer`s a

## Upgrade Notes

#### v0.8.0

You must upgrade to at least v0.7.x before upgrading to v0.8.x of this terraform code.

Breaking changes:
* The system node group is renamed and significantly modified, forcing a recreation.
* Both node groups are now locked to consistent configurations and ON\_DEMAND scheduling.
* OpenEBS is removed, and with it all support for lgalloc, our legacy spill to disk mechanism.

#### v0.7.0

This is an intermediate version to handle some changes that must be applied in stages.
Expand Down
6 changes: 3 additions & 3 deletions examples/simple/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,10 @@ module "materialize" {
}

# System node group configuration
system_node_group_node_count = 1
system_node_group_machine_type = "n2-highmem-8"
system_node_group_node_count = 2
system_node_group_machine_type = "n2-standard-4"
system_node_group_disk_size_gb = 100
system_node_group_min_nodes = 1
system_node_group_min_nodes = 2
system_node_group_max_nodes = 2

# Materialize node group configuration
Expand Down
36 changes: 0 additions & 36 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,24 +3,6 @@ locals {
managed_by = "terraform"
module = "materialize"
})

# TODO we can't delete this until we're certain no one is using it
# Disk support configuration
disk_config = {
install_openebs = var.enable_disk_support ? lookup(var.disk_support_config, "install_openebs", true) : false
run_disk_setup_script = var.enable_disk_support ? lookup(var.disk_support_config, "run_disk_setup_script", true) : false
local_ssd_count = lookup(var.disk_support_config, "local_ssd_count", 1)
create_storage_class = var.enable_disk_support ? lookup(var.disk_support_config, "create_storage_class", true) : false
openebs_version = lookup(var.disk_support_config, "openebs_version", "4.3.3")
openebs_namespace = lookup(var.disk_support_config, "openebs_namespace", "openebs")
storage_class_name = lookup(var.disk_support_config, "storage_class_name", "openebs-lvm-instance-store-ext4")
storage_class_provisioner = "local.csi.openebs.io"
storage_class_parameters = {
storage = "lvm"
fsType = "ext4"
volgroup = "instance-store-vg"
}
}
}

module "networking" {
Expand Down Expand Up @@ -51,15 +33,6 @@ module "gke" {
min_nodes = var.system_node_group_min_nodes
max_nodes = var.system_node_group_max_nodes

# We can't uninstall this until we're certain that we're no longer using it.
# Disk support configuration
enable_disk_setup = local.disk_config.run_disk_setup_script
local_ssd_count = local.disk_config.local_ssd_count
install_openebs = local.disk_config.install_openebs
openebs_namespace = local.disk_config.openebs_namespace
openebs_version = local.disk_config.openebs_version
disk_setup_image = var.disk_setup_image

namespace = var.namespace
labels = local.common_labels
}
Expand Down Expand Up @@ -213,15 +186,6 @@ locals {
swap_enabled = true
}
}
# TODO we can't delete this until we're certain no one is using it
storage = var.enable_disk_support ? {
storageClass = {
create = local.disk_config.create_storage_class
name = local.disk_config.storage_class_name
provisioner = local.disk_config.storage_class_provisioner
parameters = local.disk_config.storage_class_parameters
}
} : {}
tls = (var.use_self_signed_cluster_issuer && length(var.materialize_instances) > 0) ? {
defaultCertificateSpecs = {
balancerdExternal = {
Expand Down
Loading